From b5c6cc328f89369ebb02d7aed96efd199c80fbee Mon Sep 17 00:00:00 2001 From: Zachary Ware Date: Wed, 6 May 2026 14:18:04 -0500 Subject: [PATCH 1/2] tcltk-build: Remove Tix --- windows-release/tcltk-build.yml | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/windows-release/tcltk-build.yml b/windows-release/tcltk-build.yml index db9248e0..0cf08dbe 100644 --- a/windows-release/tcltk-build.yml +++ b/windows-release/tcltk-build.yml @@ -5,14 +5,6 @@ parameters: - name: TkSourceTag displayName: 'Tk Source Tag' type: string -- name: IncludeTix - displayName: 'Include Tix (pre-3.13)' - type: boolean - default: false -- name: TixSourceTag - displayName: 'Tix Source Tag' - type: string - default: tix-8.4.3.6 - name: SigningCertificate displayName: "Code signing certificate" type: string @@ -59,8 +51,6 @@ variables: value: ${{ parameters.TclSourceTag }} - name: TkSourceTag value: ${{ parameters.TkSourceTag }} -- name: TixSourceTag - value: ${{ parameters.TixSourceTag }} jobs: @@ -85,11 +75,6 @@ jobs: git clone $(SourcesRepo) -b $(TkSourceTag) --depth 1 "$(ExternalsDir)\$(TkSourceTag)" displayName: 'Check out Tk sources' - - ${{ if eq(parameters.IncludeTix, 'true') }}: - - powershell: | - git clone $(SourcesRepo) -b $(TixSourceTag) --depth 1 "$(ExternalsDir)\$(TixSourceTag)" - displayName: 'Check out Tix sources' - # This msbuild.rsp file will be used by the build to forcibly override these variables - powershell: | del -Force -EA 0 msbuild.rsp @@ -97,7 +82,6 @@ jobs: "/p:ExternalsDir=$(ExternalsDir)\" >> msbuild.rsp "/p:tclDir=$(ExternalsDir)\$(TclSourceTag)\" >> msbuild.rsp "/p:tkDir=$(ExternalsDir)\$(TkSourceTag)\" >> msbuild.rsp - "/p:tixDir=$(ExternalsDir)\$(TixSourceTag)\" >> msbuild.rsp displayName: 'Generate msbuild.rsp' - powershell: | @@ -115,13 +99,6 @@ jobs: & "$(msbuild)" cpython\PCbuild\tk.vcxproj "@msbuild.rsp" /p:Platform=ARM64 /p:tcltkDir="$(OutDir)\arm64" displayName: 'Build for arm64' - - ${{ if eq(parameters.IncludeTix, 'true') }}: - - powershell: | - & "$(msbuild)" cpython\PCbuild\tix.vcxproj "@msbuild.rsp" /p:Platform=Win32 /p:tcltkDir="$(OutDir)\win32" - & "$(msbuild)" cpython\PCbuild\tix.vcxproj "@msbuild.rsp" /p:Platform=x64 /p:tcltkDir="$(OutDir)\amd64" - & "$(msbuild)" cpython\PCbuild\tix.vcxproj "@msbuild.rsp" /p:Platform=ARM64 /p:tcltkDir="$(OutDir)\arm64" - displayName: 'Build Tix' - - ${{ if ne(parameters.SigningCertificate, 'Unsigned') }}: - template: sign-files.yml parameters: From 682fe85fa325625c89e43282beac95ce2b7225d6 Mon Sep 17 00:00:00 2001 From: Zachary Ware Date: Wed, 6 May 2026 14:19:42 -0500 Subject: [PATCH 2/2] tcltk-build: Split {Tcl,Tk}SourceTag into version and prefix parameters --- windows-release/tcltk-build.yml | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/windows-release/tcltk-build.yml b/windows-release/tcltk-build.yml index 0cf08dbe..d6c8cb1d 100644 --- a/windows-release/tcltk-build.yml +++ b/windows-release/tcltk-build.yml @@ -1,10 +1,18 @@ parameters: -- name: TclSourceTag - displayName: 'Tcl Source Tag' +- name: TclVersion + displayName: 'Tcl Version' type: string -- name: TkSourceTag - displayName: 'Tk Source Tag' +- name: TkVersion + displayName: 'Tk Version' + type: string +- name: TclTagPrefix + displayName: 'Tcl source tag prefix' + type: string + default: 'tcl-' +- name: TkTagPrefix + displayName: 'Tk source tag prefix' type: string + default: 'tk-' - name: SigningCertificate displayName: "Code signing certificate" type: string @@ -19,7 +27,7 @@ parameters: default: 'https://github.com/python/cpython-source-deps' -name: tcltk$(TkSourceTag)_$(Date:yyyyMMdd)$(Rev:.rr) +name: tcltk$(TkVersion)_$(Date:yyyyMMdd)$(Rev:.rr) resources: @@ -44,13 +52,17 @@ variables: - name: Configuration value: 'Release' - name: SigningDescription - value: 'Tcl/Tk for Python (${{ parameters.TclSourceTag }})' + value: 'Tcl/Tk for Python (${{ parameters.TkVersion }})' - name: SourcesRepo value: ${{ parameters.SourcesRepo }} +- name: TclVersion + value: ${{ parameters.TclVersion }} +- name: TkVersion + value: ${{ parameters.TkVersion }} - name: TclSourceTag - value: ${{ parameters.TclSourceTag }} + value: ${{ parameters.TclTagPrefix }}${{ parameters.TclVersion }} - name: TkSourceTag - value: ${{ parameters.TkSourceTag }} + value: ${{ parameters.TkTagPrefix }}${{ parameters.TkVersion }} jobs: @@ -82,6 +94,8 @@ jobs: "/p:ExternalsDir=$(ExternalsDir)\" >> msbuild.rsp "/p:tclDir=$(ExternalsDir)\$(TclSourceTag)\" >> msbuild.rsp "/p:tkDir=$(ExternalsDir)\$(TkSourceTag)\" >> msbuild.rsp + "/p:TclVersion=$(TclVersion)" >> msbuild.rsp + "/p:TkVersion=$(TkVersion)" >> msbuild.rsp displayName: 'Generate msbuild.rsp' - powershell: |