Fix clipped title in number_input_popup#86824
Fix clipped title in number_input_popup#86824dobbry-vechur wants to merge 1 commit intoCleverRaven:masterfrom
Conversation
mqrause
left a comment
There was a problem hiding this comment.
I feel like sizing to title bar is the wrong approach here. The title bar simply is not meant to hold that much information. Extra text should be moved to the description or label. Although I'm aware that autosizing with a description actually screws up the height on the first frame.
Min and max values could be a property of the popup itself, with its own hint label or something. That should shorten the titles enough.
400d6e9 to
c35c0b9
Compare
- size popup to fit title or widest description line, floor 30 chars - add set_value_range() that fills popup description - size + right-align number input via max_input_length - inline description on input row, drop trailing NewLine - add Save / Cancel buttons row, right-aligned - shorten character creation popup titles, move range to description
c35c0b9 to
b8c0de4
Compare
|
/retry |
|
Retried failed jobs: |
Thanks! will adjust. |


Summary
Bugfixes "Fix clipped title in number_input_popup"
Purpose of change
Closes #86800. Title bar got clipped by the close button on age/height/stat/skill popups during character creation.
Describe the solution
input_popup::get_bounds()sizes the popup to the wider of the title text or the longest description line, floored at 30 chars.number_input_popup::set_value_range(min, max)records the range and fills the description with a "Range: X - Y" hint, so the title can stay short.max_input_length(no parallel knob); when set the input + buttons right-align inside the row.Describe alternatives you've considered
N/A
Testing
Verified in-game.
Additional context
N/A