feat(DVLS SecretManagement Provider): Add initial module scripts#20
Open
Adam Listek (alistek) wants to merge 1 commit intomainfrom
Open
feat(DVLS SecretManagement Provider): Add initial module scripts#20Adam Listek (alistek) wants to merge 1 commit intomainfrom
Adam Listek (alistek) wants to merge 1 commit intomainfrom
Conversation
Maxime Bernier (MaximeBernier)
left a comment
Maxime Bernier (MaximeBernier)
left a comment
There was a problem hiding this comment.
Seems good. A small improvement
Comment on lines
+421
to
+428
| Function Get-DVLSCredentialEntry { | ||
| [CmdletBinding()] | ||
| Param( | ||
| [Parameter(Mandatory)] | ||
| [Object]$Session, | ||
| [Parameter(Mandatory)] | ||
| [String]$VaultId | ||
| ) |
There was a problem hiding this comment.
It should accepts a parameter name to filter more quicky the entries (the api documentation indicates it exists)
Comment on lines
+497
to
+499
| $match = Get-DVLSCredentialEntry -Session $Session -VaultId $vaultId | | ||
| Where-Object { (Get-DVLSObjectProperty -InputObject $_ -Name @('name', 'Name')) -EQ $Name } | | ||
| Select-Object -First 1 |
There was a problem hiding this comment.
Should use the name parameter mentionned above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a read-only Microsoft.PowerShell.SecretManagement provider for Devolutions Server, focused on PowerShell Universal credential retrieval.