fix: reduce app header height for compact layout#141
Merged
Conversation
Reduces header from h-24/sm:h-28 (96/112px) to h-20/sm:h-24 (80/96px), and BrandLogo from size="lg" to size="md" so the logo scales with the smaller header. Layout (sticky, backdrop blur, max-width container, right-side gap-4 stack) is preserved; items-center keeps everything vertically centered. Fixes O2sa#138
|
@mvanhorn is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
approved these changes
Apr 30, 2026
|
✨ Thank you, @mvanhorn! Another great contribution merged! 🚀 You've been a fantastic contributor! We truly appreciate your continued support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces the app header height from
h-24/sm:h-28(96/112px) toh-20/sm:h-24(80/96px) and steps theBrandLogodown fromsize="lg"tosize="md"so the logo scales with the smaller header. The sticky positioning, backdrop blur, max-width container, and right-sidegap-4stack of LanguageSwitcher/ThemeToggle are all preserved, anditems-centerkeeps everything vertically centered without further changes.Why this matters
Issue #138 (filed 2026-04-29 by @O2sa) reports the header is taking up too much vertical space and asks for a more compact layout. Looking at
components/app-header.tsxonmain, the inner div wash-24 ... sm:h-28whileBrandLogo size="lg"(defined incomponents/brand-logo.tsx) renders ath-16 sm:h-24. On desktop that left only 16px of vertical breathing room around the logo, so simply shrinking the header without also stepping the logo down would have made the logo overflow the new height.Changes
components/app-header.tsx:h-24→h-20,sm:h-28→sm:h-24,<BrandLogo size="lg" />→<BrandLogo size="md" />. Two-line change.After the change:
Testing
pnpm lintshows no new errors or warnings introduced by this change. (The pre-existinglib/i18n.ts:69set-state-in-effecterror is onmainindependently of this PR.)Fixes #138
Additionally, at the time of submission of this PR: