refactor: move ApiResponse type to a dedicated file#142
Merged
Conversation
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
@TiagoAndreAlmeida is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
approved these changes
Apr 30, 2026
|
Congratulations @TiagoAndreAlmeida 🎊 Your first contribution has been merged! 🚀 Thank you for helping improve the project. If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The
ApiResponsetype was previously defined locally withinapp/page.tsx. This refactor moves the typedefinition to
types/api-response.ts, enabling it to be shared across the frontend and API routes. Thischange improves modularity and prevents code duplication, adhering to the project's coding standards.
Fixes #137
Additionally, at the time of submission of this PR: