Skip to content

Fixed: unused manifest key: dependencies.libz-sys.package#7792

Open
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:fix-unused-manifest-key
Open

Fixed: unused manifest key: dependencies.libz-sys.package#7792
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:fix-unused-manifest-key

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented May 6, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal dependency management in the standard library to use workspace-based dependency configuration directly.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: a17435c6-49cc-474b-9161-6f2a6dee8314

📥 Commits

Reviewing files that changed from the base of the PR and between 1c43618 and ef194aa.

📒 Files selected for processing (1)
  • crates/stdlib/Cargo.toml

📝 Walkthrough

Walkthrough

The libz-sys dependency in crates/stdlib/Cargo.toml is switched from an external package name mapping (libz-rs-sys) to a direct workspace dependency reference, simplifying the dependency declaration.

Changes

libz-sys Dependency Update

Layer / File(s) Summary
Dependency Configuration
crates/stdlib/Cargo.toml
The libz-sys dependency is updated from package = "libz-rs-sys" to libz-sys = { workspace = true }, removing the package name alias.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line, so clean and bright,
libz-sys now points just right,
No more aliases to confound,
Workspace harmony we've found! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing an unused manifest key (package = "libz-rs-sys") from the libz-sys dependency declaration in Cargo.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to go as it is.

Alternatively, you can probably replace all mentions of libz-sys in RustPython with libz-rs-sys to have the same effect.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review May 7, 2026 14:46
Copy link
Copy Markdown
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changed dependency libz-rs-sys -> libz-sys . is this intended?
libz-rs-sys is pure rust replacement of libz-sys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants