Mitigate PageIndex file-descriptor buildup during long PDF indexing#44
Open
plasma16 wants to merge 6 commits intoVectifyAI:mainfrom
Open
Mitigate PageIndex file-descriptor buildup during long PDF indexing#44plasma16 wants to merge 6 commits intoVectifyAI:mainfrom
plasma16 wants to merge 6 commits intoVectifyAI:mainfrom
Conversation
Fix XLSX ingestion memory spikes with streaming parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Reduce risk of
[Errno 24] Too many open filesduring long-PDF indexing with retries.Changes
openkb/indexer.py.PageIndexClientper retry attempt.gc.collect()between failed attempts to accelerate descriptor release in long runs.Why this helps
In local mode, repeated failed/retried indexing can leave resources alive longer than expected. This patch ensures resources are released promptly per attempt.
Test evidence
python3 -m py_compile openkb/indexer.py(pass)pytestis not installed in system Python.Notes
This is an OpenKB-side mitigation while upstream
pageindexresource handling can be further hardened.