functions for copying data to buffers directly on the GPU#13
Open
micahscopes wants to merge 1 commit intoamandaghassaei:mainfrom
Open
functions for copying data to buffers directly on the GPU#13micahscopes wants to merge 1 commit intoamandaghassaei:mainfrom
micahscopes wants to merge 1 commit intoamandaghassaei:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11 I got inspired to just go ahead and implement what I was imagining.
This PR adds some utility functions for copying framebuffer data to a single buffer (
readPixelsToWebGLBuffer) and also to multiple buffers (readPixelsToMultipleWebGLBuffers). Additionally, there's a simpleGPULayer.copyToWebGLBufferthat usesreadPixelsToWebGLBuffer.This is WebGL2-only functionality. I'd like to support mobile devices in my application but I was running out of framebuffer attachments, so my plan is to concatenate a bunch of data into a single
GPULayerand use thereadPixelsToMultipleWebGLBuffersto read them out to various buffers that I can use as vertex/instance attribute buffers. This will also cut back on texture sampling.Performance is still a ❔ but hopefully it'll be better!