fix(material/select): stop event propagation on keyboard close in inl…#33210
Open
yannyannyann wants to merge 1 commit intoangular:mainfrom
Open
fix(material/select): stop event propagation on keyboard close in inl…#33210yannyannyann wants to merge 1 commit intoangular:mainfrom
yannyannyann wants to merge 1 commit intoangular:mainfrom
Conversation
…ine popover mode When mat-select uses inline popover positioning (the default), the CDK overlay host is inserted inside the mat-select host element. This caused keydown events (ENTER, SPACE, ALT+Arrow) handled by the open panel to bubble up to the host element's listener, which then ran _handleClosedKeydown and immediately re-opened the panel. Fixed by calling event.stopPropagation() in _handleOpenKeydown for the ENTER/SPACE selection and ALT+Arrow close branches. Also added a focus() call before close() in the ALT+Arrow branch so focus is explicitly restored to the trigger before the overlay detaches, consistent with the Tab and ENTER paths. This bug was particularly noticeable with screen readers since the panel would re-open immediately after selection, causing aria-expanded to toggle true→false→true in a single frame and confusing the a11y tree.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Do you have a repro for it? I don't see the select reopening on enter in our dev app here: https://ng-comp-devapp.web.app/select |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ine popover mode
When mat-select uses inline popover positioning (the default), the CDK overlay host is inserted inside the mat-select host element. This caused keydown events (ENTER, SPACE, ALT+Arrow) handled by the open panel to bubble up to the host element's listener, which then ran _handleClosedKeydown and immediately re-opened the panel.
Fixed by calling event.stopPropagation() in _handleOpenKeydown for the ENTER/SPACE selection and ALT+Arrow close branches. Also added a focus() call before close() in the ALT+Arrow branch so focus is explicitly restored to the trigger before the overlay detaches, consistent with the Tab and ENTER paths.
This bug was particularly noticeable with screen readers since the panel would re-open immediately after selection, causing aria-expanded to toggle true→false→true in a single frame and confusing the a11y tree.