Clarify KVM import template requirement#13126
Open
andrijapanicsb wants to merge 1 commit intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13126 +/- ##
=========================================
Coverage 18.09% 18.09%
- Complexity 16721 16723 +2
=========================================
Files 6037 6037
Lines 542546 542546
Branches 66431 66431
=========================================
+ Hits 98159 98170 +11
+ Misses 433368 433355 -13
- Partials 11019 11021 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Contributor
Author
|
@blueorangutan package kvm |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled withkvm SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17772 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
importUnmanagedInstancedocumentstemplateidas an optional parameter, but KVM unmanaged instance import currently requires a template and fails when one is not supplied.This updates the generated API parameter description for
templateidto explicitly mention that it is required when importing an unmanaged KVM instance. It avoids the current mismatch between API docs and runtime behavior without changing import semantics.Fixes #13067
Tests
Added
ImportUnmanagedInstanceCmdTestcoverage to verify thetemplateidAPI parameter description includes the KVM requirement.##########################################################
Generated by AI - do you REALLY think I became a Java developer overnight?
So, REVIEW PROPERLY and feel free to decline the PR if it's bunch of junk !
#########################################################