Allow preserving duplicate MACs during VM import#13128
Allow preserving duplicate MACs during VM import#13128andrijapanicsb wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #13128 +/- ##
=============================================
- Coverage 18.09% 3.52% -14.57%
=============================================
Files 6037 464 -5573
Lines 542546 40170 -502376
Branches 66431 7562 -58869
=============================================
- Hits 98159 1415 -96744
+ Misses 433368 38567 -394801
+ Partials 11019 188 -10831
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4621d57 to
e35e8d7
Compare
|
@blueorangutan package |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
e35e8d7 to
8f46ffb
Compare
|
@blueorangutan help |
|
@andrijapanicsb [SL] I understand these words: "help", "hello", "thanks", "package", "test" Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'Damans227', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87', 'RosiKyu'] |
8f46ffb to
b53c760
Compare
Description
This change adds an explicit import option to preserve duplicate NIC MAC addresses during VM import workflows.
The existing
forcedoption continues to mean: if the imported VM has a NIC MAC address that already exists on the selected CloudStack network, continue the import by generating a new MAC address.A new
allowduplicatemacaddressesAPI parameter allows the opposite behavior: preserve the imported VM's MAC address even if that same MAC is already present on the selected network. The two options are mutually exclusive.This is useful for migration cutover workflows where a VMware-sourced VM is imported to KVM while the original VM still exists in CloudStack, but the operator wants the imported instance to keep the same MAC address for guest/network continuity.
The UI import form now labels
forcedas "Generate new MAC if required" and exposes a separate "Allow duplicate MAC addresses" switch.These MAC conflict)ing) options are shown for VM migration/import flows where an existing source VM has NICs to preserve.
They are hidden when creating a brand-new VM from existing QCOW2 files on local/shared storage, because that path creates a new CloudStack NIC instead of importing a source NIC from another VM.
In other words, the MAC options are available when CloudStack has to decide what to do with a MAC address from a source VM: either keep it, generate a replacement, or fail on conflict. They are not shown for QCOW2 disk import, where there is no source VM NIC to preserve.
Types of changes
Testing
mvn -pl api -am -DskipTests installmvn -pl server -am -DskipTests compilenpm run lint -- --no-fix src/views/tools/ImportUnmanagedInstance.vueui/public/locales/en.jsongit diff --check##########################################################
Generated by AI - do you REALLY think I became a Java developer overnight?
So, REVIEW PROPERLY and feel free to decline the PR if it's bunch of junk !
#########################################################