refactor: replace chalk with Node.js built-in styleText#234
refactor: replace chalk with Node.js built-in styleText#234kbrahmateja wants to merge 1 commit intoatlassian:mainfrom
Conversation
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
🦋 Changeset detectedLatest commit: 8d4aa3a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@atlassian-cla-bot check |
|
CLA is signed. Thank you for your patience. |
kbrahmateja
left a comment
There was a problem hiding this comment.
Hello Team,
Summary of changes:
- Replaced
chalkdependency with Node.js built-inutil.styleText - Reduces external dependencies by leveraging native Node.js functionality
- All tests pass with updated snapshots
This is marked as a major version bump since it requires Node.js >= 20.12.0.
Looking forward to your feedback! 🙏
| "column": 19, | ||
| "line": 6, | ||
| "offset": 60, | ||
| "offset": 65, |
There was a problem hiding this comment.
Hi @kbrahmateja, sorry about the late review :(
I was wondering if we can avoid updating these offsets.
What
This PR removes the
chalkdependency and replaces it with Node.js built-inutil.styleTextfor terminal styling.Why
chalkand its transitive dependenciesChanges
chalkusage in validation error formatters:chalkfrompackage.jsondependenciesBreaking Change⚠️
This is a major version bump because it requires Node.js >= 20.12.0 (when
util.styleTextwas introduced).Upgrade to Rovo Dev Standard to continue using code review.