[BAE-219] Change out Chalk to styleText from Node#243
Open
dmiller113 wants to merge 3 commits intomainfrom
Open
[BAE-219] Change out Chalk to styleText from Node#243dmiller113 wants to merge 3 commits intomainfrom
dmiller113 wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 46e4fa8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
I am not exactly sure that bumping the engine up to node 20 is a patch upgrade in semver; any feedback on that choice is appreciated. |
torifat
requested changes
Apr 26, 2026
| "module": "./lib/esm/index.mjs", | ||
| "engines": { | ||
| "node": ">= 18.20.6" | ||
| "node": ">= 20.12.0" |
Collaborator
There was a problem hiding this comment.
This needs to be a major bump.
Author
There was a problem hiding this comment.
What else, if anything, should be added to help the pipeline test suite to understand the shift to node 20.12.0? There's several automated comments around styleText not existing, and I imagine it's flagging the changes as unmergable.
added 2 commits
April 27, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Issue #219
Changes
chalklibrary, to use node'sstyleTextout of theutillibrary.package.jsonto 20.12.0Rovo Dev code review: Rovo Dev couldn't review this pull request
Upgrade to Rovo Dev Standard to continue using code review.