test: trim scheduled e2e matrix and harden dev-server process cleanup#1122
Open
test: trim scheduled e2e matrix and harden dev-server process cleanup#1122
Conversation
|
Reviewed — LGTM. The dev-server process-group teardown logic looks correct ( Two minor observations (non-blocking, feel free to ignore):
|
de1bdce to
2f27d6c
Compare
Contributor
Coverage Report
|
Hweinstock
reviewed
May 5, 2026
| # Scheduled runs cover 6 priority suites spanning CodeZip, Container, Auth, | ||
| # Evals, Import, and local Dev paths. Manual workflow_dispatch runs the | ||
| # full e2e directory to exercise every framework/model-provider combo. | ||
| SCHEDULED_TESTS: >- |
Contributor
There was a problem hiding this comment.
whats the advantage of scheduled tests if we run them on every commit?
Scheduled Monday e2e run now targets 6 priority suites covering CodeZip, Container, custom JWT auth, evals, import, and local dev paths. Manual workflow_dispatch still runs the full e2e directory to exercise every framework/model-provider combo. Halves weekly AWS test burn from 6 shards of the full suite to 6 shards of the priority subset. Replace fire-and-forget SIGTERM in integ-tests/dev-server.test.ts with a process-group-aware terminator that: signals the whole group via -pid, waits on the child's exit event, and SIGKILLs the group after a 5s timeout if the process hangs. Spawn now uses detached:true so the process-group signal actually reaches subprocesses of the dev server.
0a2c8b3 to
609f73e
Compare
Hweinstock
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired PR
The CDK construct test isolation fix (`setupMocks()` mock pollution in `evaluator.test.ts`) lives in the `agentcore-l3-cdk-constructs` repo as a separate PR, since it's a different package.
Test plan