perf: reuse counter snapshot buffer in CounterGroup.OnTimer#127886
Open
unsafePtr wants to merge 1 commit intodotnet:mainfrom
Open
perf: reuse counter snapshot buffer in CounterGroup.OnTimer#127886unsafePtr wants to merge 1 commit intodotnet:mainfrom
unsafePtr wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/area-system-diagnostics-tracing |
tarekgh
reviewed
May 6, 2026
| _counters.CopyTo(counters); | ||
|
|
||
| counterCount = _counters.Count; | ||
| if (_onTimerCounters.Length < counterCount) |
Member
There was a problem hiding this comment.
race condition can be raised? The _onTimerCounters is allocated/resized and then filled using _counters.CopyTo inside the s_counterGroupLock but later it is used outside the lock. This means theoretically _onTimerCounters or its contents can be changed before executing the next foreach loop.
I would suggest instead of doing that, we can use ArrayPool?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CounterGroup.OnTimerallocates a freshDiagnosticCounter[]snapshot every poll to copy the counter list. In practice the counter set is fixed atEventSourceconstruction and rarely changes. Reuse a per-instance buffer instead, grow on demand, and clear trailing slots for disposed counters.