[cDAC] Update allowlist in LegacyFallbackHelper#127887
Open
rcj1 wants to merge 2 commits intodotnet:mainfrom
Open
[cDAC] Update allowlist in LegacyFallbackHelper#127887rcj1 wants to merge 2 commits intodotnet:mainfrom
rcj1 wants to merge 2 commits intodotnet:mainfrom
Conversation
Removed unsupported methods from the allowlist.
rcj1
changed the title
max-charlamb
approved these changes
May 6, 2026
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the cDAC legacy fallback gating so that fewer delegation-only APIs are permitted to fall back to the legacy DAC when CDAC_NO_FALLBACK=1, tightening enforcement of “no fallback” runs.
Changes:
- Removes
IXCLRDataModule.GetMethodDefinitionByTokenfrom the no-fallback allowlist. - Removes
ISOSDacInterface11.IsTrackedTypefrom the no-fallback allowlist. - Removes
ISOSDacInterface.TraverseLoaderHeapfrom the no-fallback allowlist.
Show a summary per file
| File | Description |
|---|---|
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/LegacyFallbackHelper.cs |
Shrinks the method allowlist used to permit legacy-DAC fallback in no-fallback mode. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed newly implemented methods from the allowlist.