Skip to content

improve agent friendliness of view --json#80

Open
skarim wants to merge 1 commit intoskarim/optimize-tui-loadfrom
skarim/view-json-trunk
Open

improve agent friendliness of view --json#80
skarim wants to merge 1 commit intoskarim/optimize-tui-loadfrom
skarim/view-json-trunk

Conversation

@skarim
Copy link
Copy Markdown
Collaborator

@skarim skarim commented May 6, 2026

Fix gh stack view --json returning interactive prompt

Problem

When an agent or script runs gh stack view --json and the current branch is either not in a stack or belongs to multiple stacks (e.g. a trunk branch), the command shows an interactive prompt instead of returning valid JSON.

Fix

When --json is set and the stack is ambiguous, return an exit code 2 (branch not in stack) or 6 (branch belongs to multiple stacks).


Stack created with GitHub Stacks CLIGive Feedback 💬

@skarim skarim marked this pull request as ready for review May 6, 2026 01:43
Copilot AI review requested due to automatic review settings May 6, 2026 01:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes gh stack view --json producing interactive prompts (which breaks machine-readable output) by routing JSON mode through a non-interactive stack resolution path and returning typed exit codes for ambiguous or missing stacks.

Changes:

  • Added a dedicated runViewJSON path that resolves the current stack without invoking interactive disambiguation and returns ErrNotInStack (code 2) / ErrDisambiguate (code 6) as appropriate.
  • Adjusted runView control flow so JSON mode exits early (and never shows the interactive loader/prompt flow).
  • Added tests covering --json behavior for: branch not in stack, branch in multiple stacks, and branch in a single stack (valid JSON output).
Show a summary per file
File Description
cmd/view.go Early-exits JSON mode into a new non-interactive resolver to avoid prompts and provide typed exit codes.
cmd/view_test.go Adds regression tests validating exit codes and ensuring JSON output remains valid for the single-stack case.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants