[Icons] Add AppRegistrationIcon component#1492
Open
aprv10 wants to merge 2 commits intolayer5io:masterfrom
Open
[Icons] Add AppRegistrationIcon component#1492aprv10 wants to merge 2 commits intolayer5io:masterfrom
aprv10 wants to merge 2 commits intolayer5io:masterfrom
Conversation
Signed-off-by: aprv10 <1apoorvindia@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the AppRegistrationIcon component and its local export file. Feedback was provided to improve consistency by using the DEFAULT_FILL_NONE constant and to fix a potential bug where spreading props could overwrite the fill attribute with an undefined value. Additionally, the reviewer noted that the new icon should be exported from the central icons entry point.
Signed-off-by: aprv10 <1apoorvindia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1487
Signed commits