Skip to content

TPT-2980: Add support for firewall rules version and fingerprint#656

Open
zliang-akamai wants to merge 1 commit intodevfrom
zhiwei/firewall-rules-version-fingerprint
Open

TPT-2980: Add support for firewall rules version and fingerprint#656
zliang-akamai wants to merge 1 commit intodevfrom
zhiwei/firewall-rules-version-fingerprint

Conversation

@zliang-akamai
Copy link
Copy Markdown
Member

@zliang-akamai zliang-akamai commented Feb 28, 2026

📝 Description

Add support for firewall rules version and fingerprint

✔️ How to Test

python3 -m pytest test/unit/objects/firewall_test.py
python3 -m pytest test/integration/models/firewall/test_firewall.py -k test_get_firewall_rules
python3 -m pytest test/integration/models/firewall/test_firewall.py -k test_update_firewall_rules

@zliang-akamai zliang-akamai requested a review from a team as a code owner February 28, 2026 07:30
@zliang-akamai zliang-akamai requested review from dawiddzhafarov and jriddle-linode and removed request for a team February 28, 2026 07:30
@zliang-akamai zliang-akamai force-pushed the zhiwei/firewall-rules-version-fingerprint branch from 5b15754 to 66ea575 Compare February 28, 2026 07:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds test and fixture coverage for the new version and fingerprint fields returned as part of Firewall rules, ensuring these fields are available to SDK consumers via the existing rules mapping behavior.

Changes:

  • Extend unit tests to assert Firewall.rules.version and Firewall.rules.fingerprint.
  • Extend firewall integration tests to validate version/fingerprint presence and basic types/constraints.
  • Update firewall rules fixtures to include version and fingerprint fields in mocked API responses.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/unit/objects/firewall_test.py Adds assertions that unit-loaded firewall rules expose version and fingerprint.
test/integration/models/firewall/test_firewall.py Adds integration assertions validating version/fingerprint are present and well-formed after get/update.
test/fixtures/networking_firewalls_123_rules.json Updates mocked /networking/firewalls/123/rules response to include version/fingerprint.
test/fixtures/networking_firewalls_123.json Updates mocked firewall resource fixture to include version/fingerprint inside rules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jriddle-linode
jriddle-linode previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally LGTM

@zliang-akamai zliang-akamai requested a review from a team as a code owner April 13, 2026 19:25
@zliang-akamai zliang-akamai requested review from mawilk90 and removed request for a team April 13, 2026 19:25
@zliang-akamai zliang-akamai changed the title Add support for firewall rules version and fingerprint TPT-2980: Add support for firewall rules version and fingerprint Apr 13, 2026
@zliang-akamai zliang-akamai force-pushed the zhiwei/firewall-rules-version-fingerprint branch 9 times, most recently from ee9b2e2 to 008e1c0 Compare May 7, 2026 16:12
@zliang-akamai zliang-akamai force-pushed the zhiwei/firewall-rules-version-fingerprint branch from 008e1c0 to 1b87d73 Compare May 7, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants