Skip to content

fs: extend signal option to lstat, fstat and promises API#63143

Open
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
mertcanaltin:mert/fs-stat-parity
Open

fs: extend signal option to lstat, fstat and promises API#63143
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
mertcanaltin:mert/fs-stat-parity

Conversation

@mertcanaltin
Copy link
Copy Markdown
Member

Stacked on top of #63142. Adds AbortSignal support to fs.lstat, fs.fstat, fsPromises.stat, fsPromises.lstat, fsPromises.fstat and filehandle.stat to match fs.stat. Addresses @LiviaMedeiros's parity request from #57775.

Will rebase once #63142 lands.

Refs: #57775

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 6, 2026
@mertcanaltin mertcanaltin force-pushed the mert/fs-stat-parity branch from b700b01 to face7e9 Compare May 6, 2026 05:18
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
@mertcanaltin mertcanaltin force-pushed the mert/fs-stat-parity branch from face7e9 to d310519 Compare May 7, 2026 19:42
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (1fd4949) to head (d310519).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63143   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files         713      713           
  Lines      224699   224771   +72     
  Branches    42473    42506   +33     
=======================================
+ Hits       202310   202387   +77     
+ Misses      14179    14167   -12     
- Partials     8210     8217    +7     
Files with missing lines Coverage Δ
lib/fs.js 98.21% <100.00%> (+0.01%) ⬆️
lib/internal/fs/promises.js 93.08% <100.00%> (+0.13%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants