Skip to content

quic: remove unused binding variable in session.cc#63177

Open
jasnell wants to merge 2 commits intonodejs:mainfrom
jasnell:jasnell/remove-unused-varible-in-quic
Open

quic: remove unused binding variable in session.cc#63177
jasnell wants to merge 2 commits intonodejs:mainfrom
jasnell:jasnell/remove-unused-varible-in-quic

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented May 7, 2026

Removing a couple stray unused variables.

@nodejs/quic

jasnell added 2 commits May 7, 2026 10:26
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label May 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (4f44c6f) to head (6e2ea36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63177      +/-   ##
==========================================
- Coverage   90.04%   90.03%   -0.02%     
==========================================
  Files         713      713              
  Lines      224645   224645              
  Branches    42448    42454       +6     
==========================================
- Hits       202288   202261      -27     
- Misses      14167    14176       +9     
- Partials     8190     8208      +18     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants