Fix sleeping before taking a screenshot in Map._to_png#2220
Merged
hansthen merged 2 commits intopython-visualization:mainfrom May 1, 2026
Merged
Fix sleeping before taking a screenshot in Map._to_png#2220hansthen merged 2 commits intopython-visualization:mainfrom
hansthen merged 2 commits intopython-visualization:mainfrom
Conversation
Collaborator
|
Very cool! I am running the tests as we speak, but it looks like it cannot go wrong :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the experimental
Map._to_png, currently a seleniumWebDriveropens the local HTML file andtime.sleep()is used to wait for the foliumMapto load before taking the screenshot. In this PR, I replacedtime.sleepwithWebDriverWait, which actually awaits theMaploading in JavaScript.The
delayvariable now specifies the maximum of time to wait, theWebDriverSleepobject stops waiting once the page actually loaded.Also fixed a small typo in the docstring of
_to_png.