Skip to content

Ask about regen-configure #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zware wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

Ask about regen-configure #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac9c881
Ask about regen-configure
zware May 7, 2026
df0a2a7
fixup! Ask about regen-configure
zware May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,10 @@ def bump(tag: Tag) -> None:

print("Bumped revision")
if extra_work:
print("configure.ac has changed; re-run autotools!")
if ask_question("configure.ac has changed; run 'make regen-configure'?"):
run_cmd(["make", "regen-configure"])
Comment on lines +571 to +572
Copy link
Copy Markdown
Member Author

@zware zware May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what state the repository should be in at this point, so we might need to either make -f Makefile.pre.in regen-configure or just call Tools/build/regen-configure.sh directly:

Suggested change
if ask_question("configure.ac has changed; run 'make regen-configure'?"):
run_cmd(["make", "regen-configure"])
if ask_question("configure.ac has changed; run 'make regen-configure'?"):
run_cmd(["make", "-f", "Makefile.pre.in", "regen-configure"])
Suggested change
if ask_question("configure.ac has changed; run 'make regen-configure'?"):
run_cmd(["make", "regen-configure"])
if ask_question("configure.ac has changed; run 'Tools/build/regen-configure.sh'?"):
run_cmd(["Tools/build/regen-configure.sh"])

else:
print("configure.ac has changed; re-run autotools!")
print("Please commit and use --tag")


Expand Down
Loading