Disable tests on Windows that use ed#50
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 76.79% 76.82% +0.02%
==========================================
Files 9 9
Lines 2564 2567 +3
Branches 657 657
==========================================
+ Hits 1969 1972 +3
Misses 466 466
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
No big deal but I think it would be better not to give Windows users the wrong impression that these tests are passing on Windows. I mean like this instead: --- a/src/ed_diff.rs
+++ b/src/ed_diff.rs
@@ -181,6 +181,7 @@ mod tests {
}
#[test]
+ #[cfg_attr(target_os = "windows", ignore = "no 'ed' on windows")]
fn test_permutations() {
let target = "target/ed-diff/";
// test all possible six-line files.
This prints the following instead of making the tests silently disappear on Windows: I can submit a PR but reverting 2d9e625 would unfortunately git conflict with #226 - so I won't submit anything yet. PS: following #226, it would be even better to dynamically skip based on whether |
This PR disables three tests on Windows which currently fail because there is no
edprogram. It's related to #39, though doesn't fix it.